fgerlits commented on code in PR #1349: URL: https://github.com/apache/nifi-minifi-cpp/pull/1349#discussion_r908284188
########## libminifi/test/SingleProcessorTestController.h: ########## @@ -20,6 +20,7 @@ #include <set> #include <string> #include <string_view> +#include <tuple> Review Comment: is this include still needed? ########## extensions/elasticsearch/PostElasticsearch.cpp: ########## @@ -0,0 +1,314 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + + +#include "PostElasticsearch.h" +#include <vector> +#include <utility> + +#include "ElasticsearchCredentialsControllerService.h" +#include "core/ProcessContext.h" +#include "core/ProcessSession.h" +#include "core/PropertyBuilder.h" +#include "core/Resource.h" +#include "rapidjson/document.h" +#include "rapidjson/stream.h" +#include "rapidjson/writer.h" +#include "utils/expected.h" +#include "utils/JsonCallback.h" + +namespace org::apache::nifi::minifi::extensions::elasticsearch { + +const core::Relationship PostElasticsearch::Success("success", "All flowfiles that succeed in being transferred into Elasticsearch go here."); +const core::Relationship PostElasticsearch::Failure("failure", "All flowfiles that fail for reasons unrelated to server availability go to this relationship."); +const core::Relationship PostElasticsearch::Error("error", "All flowfiles that Elasticsearch responded to with an error go to this relationship."); + +const core::Property PostElasticsearch::Action = core::PropertyBuilder::createProperty("Action") + ->withDescription("The type of the operation used to index (create, delete, index, update, upsert)") + ->supportsExpressionLanguage(true) + ->build(); Review Comment: I would mark `Action`, `Hosts` and `Index` as `isRequired(true)`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org