szaszm commented on code in PR #1372: URL: https://github.com/apache/nifi-minifi-cpp/pull/1372#discussion_r923360961
########## CMakeLists.txt: ########## @@ -68,8 +68,8 @@ option(USE_REAL_ODBC_TEST_DRIVER "Use SQLite ODBC driver in SQL extenstion unit # different than "GNU Makefiles". option (FORCE_COLORED_OUTPUT "Always produce ANSI-colored output (GNU/Clang only)." FALSE) option(AWS_ENABLE_UNITY_BUILD "If enabled, AWS SDK libraries will be built as a single, generated .cpp file. \ - This can significantly reduce static library size as well as speed up a single compilation time, but it is regenerated \ - and recompiled in every iterative build instance. Turn off to avoid recompilation." ON) + This can significantly reduce static library size as well as speed up a single compilation time, but it is regenerated \ + and recompiled in every iterative build instance. Turn off to avoid recompilation." ON) Review Comment: I think so, yes, but subjectively 4 spaces continuation in a 4 space indentation environment is not bothering my eyes as much as 2 spaces continuation, so I didn't really care. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
