[GitHub] [nifi-minifi-cpp] adamdebreceni commented on a diff in pull request #1354: MINIFICPP-1860 Integrate readability clang-tidy checks in CI

[GitBox]

adamdebreceni commented on code in PR #1354:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1354#discussion_r923482642


##########
libminifi/test/unit/BackTraceTests.cpp:
##########
@@ -41,17 +41,13 @@ class WorkerNumberExecutions : public 
utils::AfterExecute<int> {
   }
 
   bool isFinished(const int &result) override {
-    if (result > 0 && ++runs < tasks) {
-      return false;
-    } else {
-      return true;
-    }
+    return !(result > 0 && ++runs < tasks);

Review Comment:
   should we distribute the `!` over `&&`?
   ```
   result <= 0 || ++runs >= tasks
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org