lordgamez commented on code in PR #1362: URL: https://github.com/apache/nifi-minifi-cpp/pull/1362#discussion_r924404072
########## extensions/standard-processors/processors/GetFile.cpp: ########## @@ -244,7 +244,7 @@ bool GetFile::fileMatchesRequestCriteria(std::string fullName, std::string name, return false; utils::Regex rgx(request.fileFilter); - if (!utils::regexSearch(name, rgx)) { Review Comment: You are right it's a breaking change, but the reason I changed it is to be aligned with the NiFi's implementation, to have the same default value and use the same regex matching. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org