adam-markovics commented on code in PR #1328:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1328#discussion_r924439624
##########
libminifi/include/core/Repository.h:
##########
@@ -20,89 +20,77 @@
#ifndef LIBMINIFI_INCLUDE_CORE_REPOSITORY_H_
#define LIBMINIFI_INCLUDE_CORE_REPOSITORY_H_
-#include <memory>
-#include <utility>
#include <atomic>
#include <cstdint>
#include <cstring>
-#include <iostream>
#include <map>
+#include <memory>
#include <set>
#include <string>
-#include <thread>
+#include <utility>
#include <vector>
+
+#include "Core.h"
+#include "ResourceClaim.h"
+#include "core/Connectable.h"
#include "core/ContentRepository.h"
+#include "core/Property.h"
#include "core/SerializableComponent.h"
-#include "properties/Configure.h"
#include "core/logging/LoggerConfiguration.h"
-#include "core/Property.h"
-#include "ResourceClaim.h"
-#include "utils/TimeUtil.h"
-#include "utils/StringUtils.h"
-#include "Core.h"
-#include "core/Connectable.h"
-#include "core/TraceableResource.h"
+#include "properties/Configure.h"
#include "utils/BackTrace.h"
+#include "utils/Literals.h"
+#include "utils/StringUtils.h"
+#include "utils/TimeUtil.h"
#ifndef WIN32
#include <sys/stat.h>
#endif
namespace org::apache::nifi::minifi::core {
-#define REPOSITORY_DIRECTORY "./repo"
-#define MAX_REPOSITORY_STORAGE_SIZE (10*1024*1024) // 10M
+constexpr auto REPOSITORY_DIRECTORY = "./repo";
+constexpr auto MAX_REPOSITORY_STORAGE_SIZE = 10_MiB;
constexpr auto MAX_REPOSITORY_ENTRY_LIFE_TIME = std::chrono::minutes(10);
constexpr auto REPOSITORY_PURGE_PERIOD = std::chrono::milliseconds(2500);
-class Repository : public virtual core::SerializableComponent, public
core::TraceableResource {
+class Repository : public virtual core::SerializableComponent {
Review Comment:
`ThreadedRepository` is gone, in `Repository` `run` and `getThread` are
already pure virtual.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
