martinzink commented on code in PR #1370: URL: https://github.com/apache/nifi-minifi-cpp/pull/1370#discussion_r925340171
########## extensions/standard-processors/processors/NetworkListenerProcessor.cpp: ########## @@ -37,7 +38,8 @@ void NetworkListenerProcessor::onTrigger(const std::shared_ptr<core::ProcessCont } void NetworkListenerProcessor::startServer( Review Comment: Based on our conversation I think we should split this to startTCP/UDPServer and remove the arguments and create virtual functions to get max_queue_size, port, etc. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
