[GitHub] [nifi-minifi-cpp] lordgamez commented on a diff in pull request #1354: MINIFICPP-1860 Integrate readability clang-tidy checks in CI

[GitBox]

lordgamez commented on code in PR #1354:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1354#discussion_r926570096


##########
extensions/standard-processors/tests/unit/GetFileTests.cpp:
##########
@@ -40,9 +40,9 @@ namespace {
 class GetFileTestController {
  public:
   GetFileTestController();
-  [[nodiscard]] std::string getFullPath(const std::string filename) const;
+  [[nodiscard]] std::string getFullPath(const std::string& filename) const;
   [[nodiscard]] std::string getInputFilePath() const;
-  void setProperty(const core::Property& property, const std::string& value);
+  void setProperty(const core::Property& property, const std::string& value) 
const;

Review Comment:
   I agree, it should not mark in this case it according to the documentation: 
_this check will not suggest to add a const to a non-const method if the method 
reads a private member variable of pointer type because that allows to modify 
the pointee which might not preserve logical constness_ To avoid this I made 
the members private in 942ae453a3b45e8ac7eed232be0283e415a890de



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org