[GitHub] [nifi-minifi-cpp] adamdebreceni commented on a diff in pull request #1377: MINIFICPP-1865 Integrate performance clang-tidy checks in CI

[GitBox]

adamdebreceni commented on code in PR #1377:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1377#discussion_r931172292


##########
libminifi/src/c2/C2Client.cpp:
##########
@@ -177,7 +177,7 @@ std::shared_ptr<state::response::ResponseNode> 
C2Client::loadC2ResponseConfigura
             
std::static_pointer_cast<state::response::ObjectNode>(prev_node)->add_node(new_node);
           }
         } else {
-          std::string optionName = option + "." + name;
+          std::string optionName = 
std::string(option).append(".").append(name);

Review Comment:
   should we go with `StringUtils::join_pack` for such string concatenations?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org