adam-markovics commented on code in PR #1382:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1382#discussion_r940355679
##########
libminifi/src/utils/BackTrace.cpp:
##########
@@ -54,8 +54,10 @@ namespace {
} // namespace
#endif
+#ifndef HAS_EXECINFO
+void pull_trace(uint8_t) {
+#else // HAS_EXECINFO
void pull_trace(uint8_t frames_to_skip /* = 1 */) {
Review Comment:
Thanks for the idea! I didn't realize `[[maybe_unused]]` could be used on
parameters, not just return values. Fixed now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
