exceptionfactory commented on code in PR #6265: URL: https://github.com/apache/nifi/pull/6265#discussion_r941316372
########## nifi-nar-bundles/nifi-iotdb-bundle/nifi-iotdb-processors/src/main/java/org/apache/nifi/processors/PutIoTDB.java: ########## @@ -0,0 +1,286 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.nifi.processors; + +import java.io.InputStream; +import java.text.SimpleDateFormat; +import java.util.Set; +import java.util.List; +import java.util.HashMap; +import java.util.Map; +import java.util.concurrent.atomic.AtomicBoolean; + +import com.fasterxml.jackson.databind.ObjectMapper; +import org.apache.nifi.processors.model.Schema; +import org.apache.iotdb.tsfile.file.metadata.enums.TSDataType; +import org.apache.iotdb.tsfile.write.record.Tablet; +import org.apache.iotdb.tsfile.write.schema.MeasurementSchema; +import org.apache.nifi.annotation.behavior.InputRequirement; +import org.apache.nifi.annotation.documentation.CapabilityDescription; +import org.apache.nifi.annotation.documentation.Tags; +import org.apache.nifi.annotation.lifecycle.OnUnscheduled; +import org.apache.nifi.components.PropertyDescriptor; +import org.apache.nifi.expression.ExpressionLanguageScope; +import org.apache.nifi.flowfile.FlowFile; +import org.apache.nifi.processor.ProcessContext; +import org.apache.nifi.processor.ProcessSession; +import org.apache.nifi.processor.Relationship; +import org.apache.nifi.processor.exception.ProcessException; +import org.apache.nifi.processor.util.StandardValidators; +import org.apache.nifi.serialization.RecordReader; +import org.apache.nifi.serialization.RecordReaderFactory; +import org.apache.nifi.serialization.record.Record; +import org.apache.nifi.util.Tuple; + +@Tags({"iotdb", "insert", "tablet"}) +@InputRequirement(InputRequirement.Requirement.INPUT_REQUIRED) +@CapabilityDescription( + "This is a record aware processor that reads the content of the incoming FlowFile as individual records using the " + + "configured 'Record Reader' and writes them to Apache IoTDB using native interface.") +public class PutIoTDB extends AbstractIoTDB { + + static final PropertyDescriptor RECORD_READER_FACTORY = + new PropertyDescriptor.Builder() + .name("Record Reader") + .description( + "Specifies the type of Record Reader controller service to use for parsing the incoming data " + + "and determining the schema") + .identifiesControllerService(RecordReaderFactory.class) + .required(true) + .build(); + + static final PropertyDescriptor TIME_FIELD = + new PropertyDescriptor.Builder() + .name("Time Field") + .description( + "The field name which represents time. It can be updated by expression language.") + .defaultValue("Time") + .expressionLanguageSupported(ExpressionLanguageScope.FLOWFILE_ATTRIBUTES) + .addValidator(StandardValidators.NON_EMPTY_VALIDATOR) + .required(false) + .build(); + + static final PropertyDescriptor SCHEMA = + new PropertyDescriptor.Builder() + .name("Schema") + .description( + "The schema that IoTDB needs doesn't support good by NiFi.\n" + + "Therefore, you can define the schema here.\n" + + "Besides, you can set encoding type and compression type by this method.\n" + + "If you don't set this property, the inferred schema will be used.\n" + + "It can be updated by expression language.") + .expressionLanguageSupported(ExpressionLanguageScope.FLOWFILE_ATTRIBUTES) + .required(false) + .build(); + + static final PropertyDescriptor ALIGNED = + new PropertyDescriptor.Builder() + .name("Aligned") + .description("Whether using aligned interface? It can be updated by expression language.") + .allowableValues(new String[] {"true", "false"}) + .addValidator(StandardValidators.BOOLEAN_VALIDATOR) + .defaultValue("false") + .expressionLanguageSupported(ExpressionLanguageScope.FLOWFILE_ATTRIBUTES) + .required(false) + .build(); + + static final PropertyDescriptor MAX_ROW_NUMBER = + new PropertyDescriptor.Builder() + .name("Max Row Number") + .description( + "Specifies the max row number of each tablet. It can be updated by expression language.") + .addValidator(StandardValidators.POSITIVE_INTEGER_VALIDATOR) + .defaultValue("false") + .expressionLanguageSupported(ExpressionLanguageScope.FLOWFILE_ATTRIBUTES) + .required(false) + .build(); + + static { + descriptors.add(RECORD_READER_FACTORY); + descriptors.add(TIME_FIELD); + descriptors.add(SCHEMA); + descriptors.add(ALIGNED); + descriptors.add(MAX_ROW_NUMBER); + } + + @Override + protected List<PropertyDescriptor> getSupportedPropertyDescriptors() { + return descriptors; + } + + @Override + public Set<Relationship> getRelationships() { + return relationships; + } + + @Override + public void onTrigger(ProcessContext processContext, ProcessSession processSession) + throws ProcessException { + final RecordReaderFactory recordParserFactory = + processContext + .getProperty(RECORD_READER_FACTORY) + .asControllerService(RecordReaderFactory.class); + + String timeFieldProperty = processContext.getProperty(TIME_FIELD).getValue(); + String schemaProperty = processContext.getProperty(SCHEMA).getValue(); + String alignedProperty = processContext.getProperty(ALIGNED).getValue(); + String maxRowNumberProperty = processContext.getProperty(MAX_ROW_NUMBER).getValue(); + + FlowFile flowFile = processSession.get(); + + String timeField = timeFieldProperty != null ? timeFieldProperty : "Time"; + Boolean aligned = alignedProperty != null ? Boolean.valueOf(alignedProperty) : false; + int maxRowNumber = maxRowNumberProperty != null ? Integer.valueOf(maxRowNumberProperty) : 1024; + + try (final InputStream inputStream = processSession.read(flowFile); + final RecordReader recordReader = + recordParserFactory.createRecordReader(flowFile, inputStream, getLogger())) { + if (flowFile == null) { + inputStream.close(); + recordReader.close(); + processSession.transfer(flowFile, REL_SUCCESS); + return; + } + + HashMap<String, Tablet> tablets; + boolean needInitFormatter; + Schema schema; + Tuple<Boolean, String> result; + + result = + schemaProperty != null + ? validateSchemaAttribute(schemaProperty) + : validateSchema(recordReader.getSchema()); + + if (!result.getKey()) { + getLogger().error(result.getValue()); + inputStream.close(); + recordReader.close(); Review Comment: Thanks for the reply @xuanronaldo, does this occur when calling `ProcessSession.transfer()`? If you move it outside of the try-catch block, or change the `read()` signature to use a callback, that should resolve this error. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
