exceptionfactory commented on code in PR #6159:
URL: https://github.com/apache/nifi/pull/6159#discussion_r941517724
##########
nifi-nar-bundles/nifi-azure-bundle/nifi-azure-processors/src/main/java/org/apache/nifi/processors/azure/AbstractAzureDataLakeStorageProcessor.java:
##########
@@ -101,6 +101,8 @@ public abstract class AbstractAzureDataLakeStorageProcessor
extends AbstractProc
REL_FAILURE
)));
+ public static final String TEMP_FILE_DIRECTORY = "_$azuretempdirectory$";
Review Comment:
Having a reusable shared variable is helpful. I may have missed something in
previous discussion, but what is the reason for using the `$` characters?
Including `azure` in the name does not seem necessary, but providing some
association with NiFi might be helpful.
##########
nifi-nar-bundles/nifi-azure-bundle/nifi-azure-processors/src/main/java/org/apache/nifi/processors/azure/storage/ListAzureDataLakeStorage.java:
##########
@@ -129,13 +129,24 @@ public class ListAzureDataLakeStorage extends
AbstractListAzureProcessor<ADLSFil
.expressionLanguageSupported(ExpressionLanguageScope.VARIABLE_REGISTRY)
.build();
+ public static final PropertyDescriptor SHOW_TEMPORARY_FILES = new
PropertyDescriptor.Builder()
+ .name("show-temporary-files")
+ .displayName("Show temporary files")
+ .description("Whether temporary files, created during nifi upload
process should be shown." +
+ "These files are incomplete and removed after a completed
upload process.")
+ .required(true)
+ .allowableValues("true", "false")
+ .defaultValue("false")
Review Comment:
Recommend using `Boolean.TRUE.toString()` and `Boolean.FALSE.toString()`
instead of strings for consistency.
##########
nifi-nar-bundles/nifi-azure-bundle/nifi-azure-processors/src/main/java/org/apache/nifi/processors/azure/storage/PutAzureDataLakeStorage.java:
##########
@@ -83,11 +89,23 @@ public class PutAzureDataLakeStorage extends
AbstractAzureDataLakeStorageProcess
.allowableValues(FAIL_RESOLUTION, REPLACE_RESOLUTION,
IGNORE_RESOLUTION)
.build();
+ public static final PropertyDescriptor TEMP_FILE_DIRECTORY_PATH = new
PropertyDescriptor.Builder()
+ .name("temp-file-directory-path")
+ .displayName("Temp File Directory Path")
+ .description("The Path where the temporary files will be created.
The Path name cannot contain a leading '/'." +
+ " The root directory can be designated by the empty string
value. Non-existing directories will be created." +
+ "The Temp File Directory name will be " +
TEMP_FILE_DIRECTORY)
Review Comment:
```suggestion
"The Temporary File Directory name is: " +
TEMP_FILE_DIRECTORY)
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
