[GitHub] [nifi-minifi-cpp] szaszm commented on a diff in pull request #1388: MINIFICPP-1896 Change C2 component-level start/stop commands to use UUID

[GitBox]

szaszm commented on code in PR #1388:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1388#discussion_r946473092


##########
libminifi/test/integration/StateTransactionalityTests.cpp:
##########
@@ -72,8 +72,7 @@ class StatefulIntegrationTest : public IntegrationBase {
         // set hooks
         const auto processController = 
dynamic_cast<ProcessorController*>(&component);
         assert(processController != nullptr);
-        stateful_processor_ = 
dynamic_cast<StatefulProcessor*>(processController->getProcessor());
-        assert(stateful_processor_ != nullptr);

Review Comment:
   ~The return type of getProcessor is a reference now, it's always present. ~
   
   Well, I missed the fact that `dynamic_cast` can still return null. Will 
revert.



##########
libminifi/test/integration/StateTransactionalityTests.cpp:
##########
@@ -72,8 +72,7 @@ class StatefulIntegrationTest : public IntegrationBase {
         // set hooks
         const auto processController = 
dynamic_cast<ProcessorController*>(&component);
         assert(processController != nullptr);
-        stateful_processor_ = 
dynamic_cast<StatefulProcessor*>(processController->getProcessor());
-        assert(stateful_processor_ != nullptr);

Review Comment:
   ~The return type of getProcessor is a reference now, it's always present.~
   
   Well, I missed the fact that `dynamic_cast` can still return null. Will 
revert.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org