Lehel44 commented on code in PR #6300:
URL: https://github.com/apache/nifi/pull/6300#discussion_r948370365


##########
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-resources/src/main/resources/conf/logback.xml:
##########
@@ -88,6 +88,17 @@
         </encoder>
     </appender>
 
+    <appender name="DEPRECATION_FILE" 
class="ch.qos.logback.core.rolling.RollingFileAppender">
+        
<file>${org.apache.nifi.bootstrap.config.log.dir}/nifi-deprecation.log</file>
+        <rollingPolicy 
class="ch.qos.logback.core.rolling.TimeBasedRollingPolicy">
+            
<fileNamePattern>${org.apache.nifi.bootstrap.config.log.dir}/nifi-deprecation_%d.log</fileNamePattern>
+            <maxHistory>30</maxHistory>
+        </rollingPolicy>
+        <encoder class="ch.qos.logback.classic.encoder.PatternLayoutEncoder">
+            <pattern>%date %level [%thread] %logger %msg%n</pattern>

Review Comment:
   Do you think the logger name could be shortened in the layout pattern with 
an upper limit as in other examples?
   The abbreviation algorithm with examples can be found 
[here](https://logback.qos.ch/manual/layouts.html#conversionWord).
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to