martinzink commented on code in PR #1383:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1383#discussion_r954894390
##########
extensions/http-curl/client/HTTPCallback.h:
##########
@@ -53,19 +50,12 @@ namespace utils {
* - because of this, all functions that request data at a specific offset
are implicit seeks and potentially modify
* the current buffer
*/
-class HttpStreamingCallback final : public ByteInputCallback {
+class HttpStreamingCallback final : public utils::HTTPUploadCallback {
public:
- HttpStreamingCallback()
- : is_alive_(true),
- total_bytes_loaded_(0U),
- current_buffer_start_(0U),
- current_pos_(0U),
- ptr_(nullptr) {
- }
-
+ HttpStreamingCallback() = default;
~HttpStreamingCallback() override = default;
Review Comment:
good idea, I've removed these in
https://github.com/apache/nifi-minifi-cpp/pull/1383/commits/044ce269808a28e5a6eaeca34fb30747426a6ab7#diff-ba0ecec678efd02fccd01cdc5d4b580836c1d32d2608d277755742a404455b2dL55-L57
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
