exceptionfactory commented on code in PR #5369:
URL: https://github.com/apache/nifi/pull/5369#discussion_r955359353
##########
nifi-api/src/main/java/org/apache/nifi/flow/VersionedParameterContext.java:
##########
@@ -25,6 +25,9 @@ public class VersionedParameterContext extends
VersionedComponent {
private Set<VersionedParameter> parameters;
private List<String> inheritedParameterContexts;
private String description;
+ private String parameterProvider;
+ private String parameterGroupName;
+ private Boolean isSynchronized;
Review Comment:
Recommend naming this property `synchronized` to align with Bean property
naming conventions.
##########
nifi-api/src/main/java/org/apache/nifi/parameter/ParameterGroupConfiguration.java:
##########
@@ -0,0 +1,100 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.nifi.parameter;
+
+import java.util.Collections;
+import java.util.Map;
+import java.util.Objects;
+import java.util.Optional;
+
+/**
+ * User-provided configuration for a group of parameters fetched from a
ParameterProvider.
+ */
+public class ParameterGroupConfiguration implements
Comparable<ParameterGroupConfiguration> {
+
+ private final String groupName;
+
+ private final String parameterContextName;
+
+ private final Map<String, ParameterSensitivity> parameterSensitivities;
+
+ private final Boolean isSynchronized;
Review Comment:
Recommend renaming to `synchronized`. Should this property be nullable, or
should it a primitive and default to `false`?
##########
nifi-api/src/main/java/org/apache/nifi/parameter/ParameterGroupConfiguration.java:
##########
@@ -0,0 +1,100 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.nifi.parameter;
+
+import java.util.Collections;
+import java.util.Map;
+import java.util.Objects;
+import java.util.Optional;
+
+/**
+ * User-provided configuration for a group of parameters fetched from a
ParameterProvider.
+ */
+public class ParameterGroupConfiguration implements
Comparable<ParameterGroupConfiguration> {
+
+ private final String groupName;
+
+ private final String parameterContextName;
+
+ private final Map<String, ParameterSensitivity> parameterSensitivities;
+
+ private final Boolean isSynchronized;
+
+ /**
+ * Creates a named group of parameter names.
+ * @param groupName The parameter group name
+ * @param parameterContextName The parameter context name to which
parameters will be applied
+ * @param parameterSensitivities A map from parameter name to desired
sensitivity. Any parameter not included in this map will not be included
+ * when applied to the parameter context.
+ * @param isSynchronized If true, indicates that a ParameterContext should
be created if not already existing, or updated if existing
+ */
+ public ParameterGroupConfiguration(final String groupName, final String
parameterContextName, final Map<String, ParameterSensitivity>
parameterSensitivities,
+ final Boolean isSynchronized) {
Review Comment:
```suggestion
final Boolean synchronized) {
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
