markap14 commented on code in PR #6408:
URL: https://github.com/apache/nifi/pull/6408#discussion_r968806981


##########
nifi-toolkit/nifi-toolkit-cli/src/main/java/org/apache/nifi/toolkit/cli/impl/command/nifi/params/SetParam.java:
##########
@@ -88,7 +88,7 @@ public VoidResult doExecute(final NiFiClient client, final 
Properties properties
             throw new IllegalArgumentException("A parameter value is required 
when creating a new parameter");
         }
 
-        if (existingParam.isPresent() && 
existingParam.get().getValue().equals(paramValue)) {

Review Comment:
   Unclear to me at this point if the CLI supports setting a null value, but it 
probably should. If not, we may well add that in at some point, so makes sense 
to go ahead and support that at this point, anyway.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to