exceptionfactory commented on code in PR #6512:
URL: https://github.com/apache/nifi/pull/6512#discussion_r1001102672
##########
nifi-nar-bundles/nifi-azure-bundle/nifi-azure-processors/src/main/java/org/apache/nifi/processors/azure/eventhub/GetAzureEventHub.java:
##########
@@ -75,6 +77,7 @@
@WritesAttribute(attribute = "eventhub.partition", description = "The
name of the event hub partition from which the message was pulled"),
@WritesAttribute(attribute = "eventhub.property.*", description = "The
application properties of this message. IE: 'application' would be
'eventhub.property.application'")
})
+@DefaultSchedule(strategy = SchedulingStrategy.TIMER_DRIVEN, period = "1 min")
Review Comment:
With the potential for many events to come in over a short duration, this
does not seem like a good default value. Either this should be revisited, or a
much shorter default duration, such as 5 seconds might be better. The Fetch
Timeout property also impacts the behavior, so in general, it seems better to
avoid this annotation.
##########
nifi-nar-bundles/nifi-ignite-bundle/nifi-ignite-processors/src/main/java/org/apache/nifi/processors/ignite/cache/GetIgniteCache.java:
##########
@@ -53,7 +56,7 @@
@WritesAttributes({
@WritesAttribute(attribute =
GetIgniteCache.IGNITE_GET_FAILED_REASON_ATTRIBUTE_KEY, description = "The
reason for getting entry from cache"),
})
-@SeeAlso({PutIgniteCache.class})
+@DefaultSchedule(strategy = SchedulingStrategy.TIMER_DRIVEN, period = "1 min")
Review Comment:
This seems longer than needed, especially because the Processor requires an
input connection. Recommend removing this annotation.
##########
nifi-nar-bundles/nifi-cdc/nifi-cdc-mysql-bundle/nifi-cdc-mysql-processors/src/main/java/org/apache/nifi/cdc/mysql/processors/CaptureChangeMySQL.java:
##########
@@ -150,6 +152,7 @@
@WritesAttribute(attribute = "mime.type", description = "The processor
outputs flow file content in JSON format, and sets the mime.type attribute to "
+ "application/json")
})
+@DefaultSchedule(strategy = SchedulingStrategy.TIMER_DRIVEN, period = "1 min")
Review Comment:
This does not seem like a good setting for `CaptureChangeMySQL` because the
Processor must be triggered in order to pull events from the internal queue.
Recommend removing the annotation.
##########
nifi-nar-bundles/nifi-aws-bundle/nifi-aws-processors/src/main/java/org/apache/nifi/processors/aws/sqs/GetSQS.java:
##########
@@ -64,6 +66,7 @@
@WritesAttribute(attribute = "sqs.message.id", description = "The unique
identifier of the SQS message"),
@WritesAttribute(attribute = "sqs.receipt.handle", description = "The SQS
Receipt Handle that is to be used to delete the message from the queue")
})
+@DefaultSchedule(strategy = SchedulingStrategy.TIMER_DRIVEN, period = "1 min")
Review Comment:
Similar to `GetAzureEventHub`, it seems like this Processor needs to be run
more often. Recommend removing the annotation from this set of changes and
revisiting.
##########
nifi-nar-bundles/nifi-aws-bundle/nifi-aws-processors/src/main/java/org/apache/nifi/processors/aws/dynamodb/GetDynamoDB.java:
##########
@@ -79,6 +81,7 @@
@ReadsAttribute(attribute =
AbstractDynamoDBProcessor.DYNAMODB_ITEM_HASH_KEY_VALUE, description = "Items
hash key value" ),
@ReadsAttribute(attribute =
AbstractDynamoDBProcessor.DYNAMODB_ITEM_RANGE_KEY_VALUE, description = "Items
range key value" ),
})
+@DefaultSchedule(strategy = SchedulingStrategy.TIMER_DRIVEN, period = "1 min")
Review Comment:
As with other event-based components, this seems too long.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
