fgerlits commented on code in PR #1419: URL: https://github.com/apache/nifi-minifi-cpp/pull/1419#discussion_r1004284211
########## extensions/standard-processors/processors/PutTCP.h: ########## @@ -0,0 +1,121 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +#pragma once + +#include <cstddef> +#include <memory> +#include <string> +#include <vector> +#include <unordered_map> +#include <utility> + +#include "Processor.h" +#include "utils/Export.h" +#include "controllers/SSLContextService.h" + +#include "utils/expected.h" +#include "utils/StringUtils.h" // for string <=> on libc++ + +namespace org::apache::nifi::minifi::processors { + +class ConnectionId { + public: + ConnectionId(std::string hostname, std::string port) : hostname_(std::move(hostname)), port_(std::move(port)) {} + + struct hash { + std::size_t operator () (const ConnectionId& connection_id) const { + return utils::hash_combine(std::hash<std::string>{}(connection_id.hostname_), std::hash<std::string>{}(connection_id.port_)); + } + }; + + auto operator<=>(const ConnectionId&) const = default; + + std::string& getHostname() { return hostname_; } + std::string& getPort() { return port_; } Review Comment: could these return `const std::string&` or `std::string_view`? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
