nandorsoma commented on code in PR #6619:
URL: https://github.com/apache/nifi/pull/6619#discussion_r1014953245
##########
nifi-nar-bundles/nifi-elasticsearch-bundle/nifi-elasticsearch-client-service-api/src/main/java/org/apache/nifi/elasticsearch/ElasticSearchClientService.java:
##########
@@ -52,23 +54,63 @@ public interface ElasticSearchClientService extends
ControllerService {
.addValidator(Validator.VALID)
.build();
PropertyDescriptor PROXY_CONFIGURATION_SERVICE =
ProxyConfiguration.createProxyConfigPropertyDescriptor(false, ProxySpec.HTTP);
+
+ AllowableValue ALLOWABLE_VALUE_BASIC_AUTH = new
AllowableValue(AuthorizationScheme.BASIC.name(),
AuthorizationScheme.BASIC.getDisplayName());
+ AllowableValue ALLOWABLE_VALUE_API_KEY = new
AllowableValue(AuthorizationScheme.API_KEY.name(),
AuthorizationScheme.API_KEY.getDisplayName());
+
+ PropertyDescriptor AUTHORIZATION_SCHEME = new PropertyDescriptor.Builder()
+ .name("authorization-scheme")
+ .displayName("Authorization Scheme")
+ .description("Authorization Scheme used for the authorization.")
+ .allowableValues(ALLOWABLE_VALUE_BASIC_AUTH,
ALLOWABLE_VALUE_API_KEY)
Review Comment:
Good idea! I didn't know about that interface. I'm wondering, wouldn't it
make sense to create a matching signature for the `dependsOn` and
`defaultValue` methods? If so I'd be happy to create a followup on that.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
