adamdebreceni commented on code in PR #1447:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1447#discussion_r1023736739
##########
libminifi/include/core/ProcessSession.h:
##########
@@ -155,16 +156,25 @@ class ProcessSession : public ReferenceContainer {
std::shared_ptr<FlowFile> snapshot;
};
+ using Relationships = utils::ValueIdProvider<Relationship>;
+
+ Relationships relationships_;
Review Comment:
I would rather we use ids, we could configure the id (compressed_type) to be
smaller than 8 bytes, we also can't accidentally dereference an invalid pointer
(although we could decompress what was compressed with another compressor, that
would not be UB at least)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
