KalmanJantner commented on PR #6589:
URL: https://github.com/apache/nifi/pull/6589#issuecomment-1358960221
> Playing with this PR. Some remarks:
>
> * set mime.type to json when we know that the generated flow file is going
to contain a JSON payload (example: StartAwsTextractJob,
GetAwsTextractJobStatus, etc).
> * please set description on all properties and enum values where it makes
sense. We should not assume the user knows the difference between Text Analysis
and Document Text Detection for example (in StartAwsTextractJob).
> * please add additionalDetails with examples of expected JSON payloads +
links to AWS documentation if that makes sense (example: StartAwsTextractJob)
> * the type of extract in GetAwsTextractJobStatus is a string and not an
enum. If that's because we want to be able to reference a flow file attribute,
then we should directly reference the flow file attribute that we created in
StartAwsTextractJob. In this case: `${type-of-service}`. However when trying to
use EL, it fails because it's not one of the allowable values. Something to fix
here.
Thank you for the comments, I went through and fixed them.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
