[
https://issues.apache.org/jira/browse/NIFI-9164?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17652600#comment-17652600
]
Nissim Shiman edited comment on NIFI-9164 at 12/28/22 9:09 PM:
---------------------------------------------------------------
This is trickier than the usual steps for junit4 to junit5 conversions as there
are custom classloader workarounds that need to be done here [1][2] that fit in
well with Junit 4 RunsWith, but do not have corresponding hooks for it in
junit5.
This is a known issue [3], with a fix currently targeted for the next release
of junit5 (5.10.0-M1) [4]
This being said, this issue has been known and discussed extensively for the
past 6 years [5] , so it is unclear it will make it into junit 5, until it
actually happens, although the recent refocus on it [3] is encouraging.
[1]
[https://github.com/apache/nifi/blob/rel/nifi-1.19.1/nifi-nar-bundles/nifi-windows-event-log-bundle/nifi-windows-event-log-processors/src/test/java/org/apache/nifi/processors/windows/event/log/ConsumeWindowsEventLogTest.java#L64]
[2]
[https://github.com/apache/nifi/blob/rel/nifi-1.19.1/nifi-nar-bundles/nifi-windows-event-log-bundle/nifi-windows-event-log-processors/src/test/java/org/apache/nifi/processors/windows/event/log/JNAJUnitRunner.java#L27]
[3] [https://github.com/junit-team/junit5/issues/3028]
[4] [https://github.com/junit-team/junit5/milestone/65]
[5] [https://github.com/junit-team/junit5/issues/201]
was (Author: nissim shiman):
This is trickier than the usual steps for junit4 to junit5 conversions as there
are custom classloader workarounds that need to be done here [1][2] that fit in
well with Junit 4 RunsWith, but do not have corresponding hooks for it in
junit5.
This is a known issue [3], with a fix currently targeted for the next release
of junit5 (5.10.0-M1) [4]
This being said, this issue has been known and discussed extensively for the
past 6 years [5] , so it is unclear it will make it into junit 5, until it
actually happens, although the recent refocus on it [4] is encouraging.
[1]
[https://github.com/apache/nifi/blob/rel/nifi-1.19.1/nifi-nar-bundles/nifi-windows-event-log-bundle/nifi-windows-event-log-processors/src/test/java/org/apache/nifi/processors/windows/event/log/ConsumeWindowsEventLogTest.java#L64]
[2]
[https://github.com/apache/nifi/blob/rel/nifi-1.19.1/nifi-nar-bundles/nifi-windows-event-log-bundle/nifi-windows-event-log-processors/src/test/java/org/apache/nifi/processors/windows/event/log/JNAJUnitRunner.java#L27]
[3] [https://github.com/junit-team/junit5/issues/3028]
[4] [https://github.com/junit-team/junit5/milestone/65]
[5] [https://github.com/junit-team/junit5/issues/201]
> Refactor nifi-windows-event-log-bundle to use JUnit 5
> -----------------------------------------------------
>
> Key: NIFI-9164
> URL: https://issues.apache.org/jira/browse/NIFI-9164
> Project: Apache NiFi
> Issue Type: Sub-task
> Reporter: Mike Thomsen
> Assignee: Nissim Shiman
> Priority: Minor
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
