[GitHub] [nifi] exceptionfactory commented on a diff in pull request #6779: NIFI-10975 Add Kubernetes Leader Election and State Provider

[GitBox]

exceptionfactory commented on code in PR #6779:
URL: https://github.com/apache/nifi/pull/6779#discussion_r1063741104


##########
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-api/src/main/java/org/apache/nifi/web/StandardNiFiServiceFacade.java:
##########
@@ -6261,8 +6261,8 @@ private Set<String> getRoles(final NodeIdentifier nodeId) 
{
         final String nodeAddress = nodeId.getSocketAddress() + ":" + 
nodeId.getSocketPort();
 
         for (final String roleName : ClusterRoles.getAllRoles()) {
-            final String leader = leaderElectionManager.getLeader(roleName);
-            if (leader == null) {
+            final Optional<String> leader = 
leaderElectionManager.getLeader(roleName);

Review Comment:
   Thanks for catching that, I missed pushing that change through to that 
comparison. Will push a correction.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org