martinzink commented on code in PR #1457:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1457#discussion_r1066881433
##########
libminifi/test/Utils.h:
##########
@@ -166,10 +170,10 @@ struct FlowFileQueueTestAccessor {
FIELD_ACCESSOR(queue_);
};
-bool sendMessagesViaSSL(const std::vector<std::string_view>& contents,
- const asio::ip::tcp::endpoint& remote_endpoint,
- const std::filesystem::path& ca_cert_path,
- const std::optional<minifi::utils::net::SslData>&
ssl_data = std::nullopt) {
+std::error_code sendMessagesViaSSL(const std::vector<std::string_view>&
contents,
+ const asio::ip::tcp::endpoint&
remote_endpoint,
+ const std::filesystem::path& ca_cert_path,
+ const
std::optional<minifi::utils::net::SslData>& ssl_data = std::nullopt) {
Review Comment:
I see your point, I squeezed in this change as well in
https://github.com/apache/nifi-minifi-cpp/pull/1457/commits/653894f83c9464edda7d5238408937074f51c34c#diff-eb32155f3c36cff6b7fb634b81ae2288627fae11502496cee252b9493e45bb4aR174-R178
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
