szaszm commented on code in PR #1491: URL: https://github.com/apache/nifi-minifi-cpp/pull/1491#discussion_r1068329580
########## CMakeLists.txt: ########## @@ -106,7 +106,7 @@ if (WIN32) endif() if (WIN32) - add_definitions(-DSERVICE_NAME="Apache NiFi MINiFi") + add_definitions(-DMINIFI_SERVICE_NAME="Apache NiFi MINiFi") Review Comment: What's the reason for the rename? Would this be solved by changing to target_compile_definitions? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
