NissimShiman commented on PR #6770: URL: https://github.com/apache/nifi/pull/6770#issuecomment-1382068327
Thank you very much @mattyb149 for looking at this! You raise a very good point about why we don't have an EL validator for non-stateful mode. This issue started when stateful was added [NIFI-1582](https://issues.apache.org/jira/browse/NIFI-1582), as part of a large [commit](https://github.com/apache/nifi/commit/e36b37692c528b2e9774f9f49737eb2d1a05960f#diff-7f99fec326074ddcb38d63156204fbcff6693bf7dc5eedd60c6a477af00d608b) There is a discussion that touches on it [here](https://github.com/apache/nifi/pull/319#discussion_r59995999) but it is unclear why this functionality was removed for stateless. My best guess is this was an oversight that slipped in due to the many other things happening in that commit. I just tested it before and after the fix and in both cases the flowfiles will accumulate on input queue and age off (if age off is set). Also, if flow containing UpdateAttribute with malformed EL is in registry, it can be put under version control before the fix and nifi can be updated with fix and/or a new instance of flow can be pulled to nifi (after the fix) without issues (i.e. there will be a green checkbox on the process group in both these cases). So the sanity checks pass as far as existing users seeing new behavior that could cause them concern so we should be good, but hopefully @markap14 can take a quick look to see if something is being overlooked here. In any event, thank you once again @mattyb149. I greatly appreciate you taking the time to look at this! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
