szaszm commented on code in PR #1456:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1456#discussion_r1071415382


##########
docker/test/integration/MiNiFi_integration_test_driver.py:
##########
@@ -311,3 +311,15 @@ def check_metric_class_on_prometheus(self, metric_class, 
timeout_seconds):
 
     def check_processor_metric_on_prometheus(self, metric_class, 
timeout_seconds, processor_name):
         assert 
self.cluster.wait_for_processor_metric_on_prometheus(metric_class, 
timeout_seconds, processor_name)
+
+    def check_minimum_peak_memory_usage(self, minimum_peak_memory_usage: int, 
timeout_seconds: int) -> None:
+        assert 
self.cluster.wait_for_peak_memory_usage_to_exceed(minimum_peak_memory_usage, 
timeout_seconds)
+
+    def check_maximum_memory_usage(self, maximum_memory_usage: int, 
timeout_seconds: int) -> None:
+        assert 
self.cluster.wait_for_memory_usage_to_drop_below(maximum_memory_usage, 
timeout_seconds)

Review Comment:
   I think the rename would make sense here as well



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to