szaszm commented on code in PR #1474:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1474#discussion_r1085117807
##########
libminifi/include/CronDrivenSchedulingAgent.h:
##########
@@ -45,8 +45,6 @@ class CronDrivenSchedulingAgent : public
ThreadedSchedulingAgent {
: ThreadedSchedulingAgent(controller_service_provider, std::move(repo),
std::move(flow_repo), std::move(content_repo), std::move(configuration),
thread_pool) {
}
- CronDrivenSchedulingAgent(const CronDrivenSchedulingAgent& parent) = delete;
- CronDrivenSchedulingAgent& operator=(const CronDrivenSchedulingAgent&
parent) = delete;
Review Comment:
I don't think it's a bad thing to repeat the copy/move deletion in derived
classes, because it provides more information locally, but it's fine like this
as well.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
