fgerlits commented on code in PR #1498: URL: https://github.com/apache/nifi-minifi-cpp/pull/1498#discussion_r1088750787
########## minifi_main/MiNiFiWindowsService.h: ########## @@ -20,10 +20,12 @@ #ifdef WIN32 #include <memory> +#include <utility> + #include "core/Core.h" void RunAsServiceIfNeeded(); -HANDLE GetTerminationEventHandle(bool* isStartedByService); +std::tuple<bool, HANDLE> GetTerminationEventHandle(); Review Comment: we only call this function from one place, and the parts are named where we call it, so I'm not sure it's worth it did you mean something like this? https://github.com/fgerlits/nifi-minifi-cpp/commit/02a2b692c4d924dfbb522ac0eb71a007c84dbd69 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
