exceptionfactory commented on code in PR #6899:
URL: https://github.com/apache/nifi/pull/6899#discussion_r1094610345
##########
nifi-nar-bundles/nifi-gcp-bundle/nifi-gcp-processors/src/main/java/org/apache/nifi/processors/gcp/vision/StartGcpVisionAnnotateImagesOperation.java:
##########
@@ -55,21 +55,21 @@ public class StartGcpVisionAnnotateImagesOperation extends
AbstractStartGcpVisio
" }\n" +
" },\n" +
" \"features\": [{\n" +
- " \"type\": \"FACE_DETECTION\",\n" +
+ " \"type\": \"${feature-type}\",\n" +
Review Comment:
```suggestion
" \"type\": \"${vision-feature-type}\",\n" +
```
##########
nifi-nar-bundles/nifi-gcp-bundle/nifi-gcp-processors/src/main/java/org/apache/nifi/processors/gcp/vision/StartGcpVisionAnnotateFilesOperation.java:
##########
@@ -56,12 +56,12 @@ public class StartGcpVisionAnnotateFilesOperation extends
AbstractStartGcpVision
" \"mimeType\": \"application/pdf\"\n" +
" },\n" +
" \"features\": [{\n" +
- " \"type\":
\"DOCUMENT_TEXT_DETECTION\",\n" +
+ " \"type\": \"${feature-type}\",\n" +
Review Comment:
This needs to be adjusted to `vision-feature-type`:
```suggestion
" \"type\":
\"${vision-feature-type}\",\n" +
```
##########
nifi-nar-bundles/nifi-gcp-bundle/nifi-gcp-processors/src/main/resources/docs/org.apache.nifi.processors.gcp.vision.StartGcpVisionAnnotateImagesOperation/additionalDetails.html:
##########
@@ -53,13 +53,13 @@ <h3>Payload</h3>
}
},
"features": [{
- "type": "DOCUMENT_TEXT_DETECTION",
+ "type": "${feature-type}",
Review Comment:
```suggestion
"type": "${vision-feature-type}",
```
##########
nifi-nar-bundles/nifi-gcp-bundle/nifi-gcp-processors/src/main/resources/docs/org.apache.nifi.processors.gcp.vision.StartGcpVisionAnnotateFilesOperation/additionalDetails.html:
##########
@@ -55,12 +55,12 @@ <h3>Payload</h3>
"mimeType": "application/pdf"
},
"features": [{
- "type": "DOCUMENT_TEXT_DETECTION",
+ "type": "${feature-type}",
Review Comment:
```suggestion
"type": "${vision-feature-type}",
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
