fgerlits commented on code in PR #1485: URL: https://github.com/apache/nifi-minifi-cpp/pull/1485#discussion_r1098475395
########## libminifi/src/core/repository/VolatileRepository.cpp: ########## @@ -23,16 +23,141 @@ #include <vector> #include "FlowFileRecord.h" -namespace org { -namespace apache { -namespace nifi { -namespace minifi { -namespace core { -namespace repository { - -} /* namespace repository */ -} /* namespace core */ -} /* namespace minifi */ -} /* namespace nifi */ -} /* namespace apache */ -} /* namespace org */ +namespace org::apache::nifi::minifi::core::repository { + +void VolatileRepository::loadComponent(const std::shared_ptr<core::ContentRepository>& /*content_repo*/) { +} + +VolatileRepository::~VolatileRepository() { +} Review Comment: this could be removed now -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org