lordgamez commented on PR #1507: URL: https://github.com/apache/nifi-minifi-cpp/pull/1507#issuecomment-1425946378
> Could you explain what's happening here? Why do we have to wait for memory usage to decrease after a small increase? Why do we have to wait more and allow a larger difference? Did minifi become heavier over time, or is there something else at play? According to @adebreceni the original intent for this test was to check if the allocated memory in the filesystem repository is getting freed after writing the content which is 20MB in this test, so any memory check below 20MB should be sufficient. In very rare cases the memory used by MiNiFi can go above 1MB during the test (which is the original check limit) so it may fail. Usually the memory usage was about 2MB in failure cases, so 5MB should be more than enough to check for. There is also a time limit for this check to allow some time for the agent to release the memory, not just the exact time point after calling the `write()` function. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
