[ https://issues.apache.org/jira/browse/MINIFICPP-2024?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Gábor Gyimesi resolved MINIFICPP-2024. -------------------------------------- Fix Version/s: 0.14.0 Resolution: Fixed > Clean up repository inheritance hierarchy > ----------------------------------------- > > Key: MINIFICPP-2024 > URL: https://issues.apache.org/jira/browse/MINIFICPP-2024 > Project: Apache NiFi MiNiFi C++ > Issue Type: Improvement > Reporter: Gábor Gyimesi > Assignee: Gábor Gyimesi > Priority: Major > Fix For: 0.14.0 > > Time Spent: 1h 50m > Remaining Estimate: 0h > > We would like to handle all repositories the same way for reporting metrics > in MINIFICPP-2022 but the current hierarchy structure does not allow that to > be done easily. > The inheritance hierarchy of repositories is unnecessarily too complex. > While the base of the flow repositories is core::Repository and the base of > content repositories is core::ContentRepository, the > VolatileContentRepository inherits from both that does not seem logical. > The VolatileRepository is a template class that only works with two specific > set of template argument and has unnecessary implementations of base classes > that is not valid for all child volatile repositories. > There is also a virtual inheritance from core::SerializableComponent for flow > repositories that should not be needed to be virtual. > This hierarchy should be cleaned up to be able to create a single interface > for all repositories for metric reporting. > -- This message was sent by Atlassian Jira (v8.20.10#820010)