Github user mcgilman commented on a diff in the pull request:
https://github.com/apache/nifi/pull/1247#discussion_r88902132
--- Diff:
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-framework-core/src/main/java/org/apache/nifi/controller/service/StandardControllerServiceNode.java
---
@@ -121,6 +122,11 @@ public Resource getResource() {
}
@Override
+ public boolean isRestricted() {
--- End diff --
This cannot be moved as the logic to get the underlying class is not
consistent between Processor's, Controller Service's, and Reporting Task's.
Alternatively, we could introduce another method that is responsible for
returning the underlying instance type. This would allow us to move
`isRestricted` up but I didn't think it was necessary.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
