Lehel44 commented on code in PR #6959:
URL: https://github.com/apache/nifi/pull/6959#discussion_r1120139647
##########
nifi-nar-bundles/nifi-salesforce-bundle/nifi-salesforce-processors/src/main/java/org/apache/nifi/processors/salesforce/util/SalesforceRestService.java:
##########
@@ -103,6 +103,10 @@ public InputStream postRecord(String sObjectApiName,
String body) {
return request(request);
}
+ public String getVersionedBaseUrl() {
+ return baseUrl + "/services/data/v" + version;
+ }
+
private InputStream request(Request request) {
Review Comment:
I recommend refactoring this method a little bit.
```private InputStream request(Request request) {
try (Response response = httpClient.newCall(request).execute()) {
if (response.code() < 200 || response.code() > 201) {
throw new ProcessException("Invalid response" +
" Code: " + response.code() +
" Message: " + response.message() +
" Body: " + (response.body() == null ? null :
response.body().string())
);
}
return Objects.requireNonNull(response.body()).byteStream();
} catch(ProcessException e) {
throw e;
} catch (Exception e) {
throw new ProcessException(String.format("Salesforce HTTP
request failed [%s]", request.url()), e);
}
}```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
