exceptionfactory commented on PR #6995: URL: https://github.com/apache/nifi/pull/6995#issuecomment-1449258278
Thanks for the thoughtful reply @ChrisSamo632. For the simple things first, it seems like the following items could be pulled out to a simpler PR: - address shellcheck errors/warnings in the Docker Image start scripts - update maven-antrun-plugin for dockermaven builds The changes for NiFi Registry also seem self-contained, but might involve a little more review. Loading properties from files would be a helpful general improvement to properties loading. I could see that as either an incremental improvement, or part of a more generalized adjustment to property loading. The work around Sensitive Property Providers for loading values from secrets managers introduced some abstractions for NiFiProperties, which may need to be evaluated as part of the approach. One of the short-comings of the current Docker container is the need to define environment variables and map them to properties in the script. This requires manual updates to support additional properties. One the major advantages of moving environment variable loading into the application would be supporting convention-based mapping. This is a standard feature of Spring Boot, and provides a good pattern. With bootstrap.conf, it should be possible to select the property sources, perhaps the default is the current file properties, but the Docker image would set the value use convention-based environment variables. NiFi Registry is the only application component that uses Spring Boot, so I'm not suggesting we need to move in that direction, just that we should able to follow the same basic idea of convention-based environment variable mapping. Those are my initial thoughts. I'm sure others like @kevdoran have some ideas along these lines. With that, if you're interested in carving out some of these things, I think that would be useful, and we should put some thought into a new Jira issue that encompasses the goals of NIFI-7060. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
