martinzink commented on code in PR #1504:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1504#discussion_r1126980935
##########
win_build_vs.bat:
##########
@@ -119,7 +119,7 @@ cmake -G %generator% %build_platform_cmd%
-DINSTALLER_MERGE_MODULES=%installer_m
-DENABLE_NANOFI=%build_nanofi% -DENABLE_OPENCV=%build_opencv%
-DENABLE_PROMETHEUS=%build_prometheus% -DENABLE_ELASTICSEARCH=%build_ELASTIC%
-DUSE_SHARED_LIBS=OFF -DDISABLE_CONTROLLER=ON ^
-DENABLE_BUSTACHE=%enable_bustache% -DENABLE_COAP=%enable_coap%
-DENABLE_ENCRYPT_CONFIG=%enable_encrypt_config% -DENABLE_GPS=%enable_gps%
-DENABLE_LUA_SCRIPTING=%enable_lua_scripting% ^
-DENABLE_MQTT=%enable_mqtt% -DENABLE_OPC=%enable_opc%
-DENABLE_OPENWSMAN=%enable_openwsman% -DENABLE_OPS=%enable_ops%
-DENABLE_PCAP=%enable_pcap% ^
- -DENABLE_SCRIPTING=%enable_scripting%
-DENABLE_SENSORS=%enable_sensors% -DENABLE_TENSORFLOW=%enable_tensorflow%
-DENABLE_USB_CAMERA=%enable_usb_camera% ^
+ -DENABLE_PYTHON_SCRIPTING=%enable_python_scripting%
-DENABLE_SENSORS=%enable_sensors% -DENABLE_TENSORFLOW=%enable_tensorflow%
-DENABLE_USB_CAMERA=%enable_usb_camera% ^
Review Comment:
good idea, I (and from the looks of it I am not alone :sweat_smile: ) always
forget that file. I've updated and added the missing flags aswell.
https://github.com/apache/nifi-minifi-cpp/pull/1504/commits/9efeaee66bc4b89ff75a527f9c65ae23a93cb9c9
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
