adamdebreceni commented on code in PR #1490:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1490#discussion_r1129354900


##########
libminifi/src/core/repository/VolatileRepository.cpp:
##########
@@ -71,6 +71,9 @@ bool VolatileRepository::Put(const std::string& key, const 
uint8_t *buf, size_t
     }
   } while (!updated);
   repo_data_.current_size += size;
+  if (repo_data_.current_entry_count < repo_data_.max_count) {
+    ++repo_data_.current_entry_count;

Review Comment:
   why conditionally increment the `current_entry_count`? size seems to be 
always incremented



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to