martinzink commented on PR #1536: URL: https://github.com/apache/nifi-minifi-cpp/pull/1536#issuecomment-1477486447
> I'm fine with this, but do we even need to check the logs? `trigger_expect_failure` already checked that the flow file was routed to Failure; that may be enough. You are probably right, originally it clearly documented the reason behind the failure, but now that I look at it these 6-7 lines (and I'm not sure if this covers every possible failure message on every supported platform), its probably not really useful anymore. I've removed them in https://github.com/apache/nifi-minifi-cpp/pull/1536/commits/0c73a5bedb726660109ced05f7639e2c6f636dc5 I rerequested the reviews because this makes them moot. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
