[ https://issues.apache.org/jira/browse/NIFI-2655?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15688192#comment-15688192 ]
ASF GitHub Bot commented on NIFI-2655: -------------------------------------- GitHub user alopresto opened a pull request: https://github.com/apache/nifi/pull/1262 [WIP] NIFI-2655 This PR is already rebased against [PR 1261](https://github.com/apache/nifi/pull/1261) so it should not be merged to `master` until after that PR is merged. Once that occurs, this PR will drop to a much [smaller changeset](https://github.com/apache/nifi/commit/0633cbac5d27b41ce232e11ea96592e19218445e). Thank you for submitting a contribution to Apache NiFi. In order to streamline the review of the contribution we ask you to ensure the following steps have been taken: ### For all changes: - [x] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message? - [x] Does your PR title start with NIFI-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character. - [x] Has your PR been rebased against the latest commit within the target branch (typically master)? - [x] Is your initial contribution a single, squashed commit? ### For code changes: - [x] Have you ensured that the full suite of tests is executed via mvn -Pcontrib-check clean install at the root nifi folder? - [x] Have you written or updated unit tests to verify your changes? - [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)? - [ ] If applicable, have you updated the LICENSE file, including the main LICENSE file under nifi-assembly? - [ ] If applicable, have you updated the NOTICE file, including the main NOTICE file found under nifi-assembly? - [ ] If adding new Properties, have you added .displayName in addition to .name (programmatic access) for each of the new properties? ### For documentation related changes: - [ ] Have you ensured that format looks appropriate for the output in which it is rendered? ### Note: Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible. You can merge this pull request into a Git repository by running: $ git pull https://github.com/alopresto/nifi NIFI-2655 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/nifi/pull/1262.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1262 ---- commit 1b2d79010ef50d54ec01fad4318c2889acee0b42 Author: Andy LoPresto <alopre...@apache.org> Date: 2016-11-22T05:19:18Z NIFI-3024 Added key migration for sensitive processor properties contained in flow.xml.gz. (nifi.sensitive.props.key) commit 0633cbac5d27b41ce232e11ea96592e19218445e Author: Andy LoPresto <alopre...@apache.org> Date: 2016-11-22T22:49:33Z NIFI-2655 Implemented logic check for missing -n or -l arguments. Added and updated unit tests. Cleaned up unnecessary and commented code. Removed ignored unit tests. ---- > Encrypted config tool should handle absence of "-n" flag > -------------------------------------------------------- > > Key: NIFI-2655 > URL: https://issues.apache.org/jira/browse/NIFI-2655 > Project: Apache NiFi > Issue Type: Improvement > Components: Configuration, Tools and Build > Affects Versions: 1.0.0 > Reporter: Andy LoPresto > Assignee: Andy LoPresto > Priority: Minor > Labels: config, security > Fix For: 1.2.0 > > > The {{encrypt-config}} tool will fail if the source {{-n nifi.properties}} > flag is not present. However, it first looks for {{./conf/nifi.properties}} > before failing. Either {{-n}} should be a required flag or a default > {{nifi.properties}} template file should be populated within the tool. -- This message was sent by Atlassian JIRA (v6.3.4#6332)