szaszm commented on code in PR #1543:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1543#discussion_r1161202029
##########
libminifi/src/Configuration.cpp:
##########
@@ -179,9 +179,9 @@ std::vector<std::string>
Configuration::getSensitiveProperties(const std::functi
}
bool Configuration::validatePropertyValue(const std::string& property_name,
const std::string& property_value) {
- for (const auto& config_property: Configuration::CONFIGURATION_PROPERTIES) {
- if (config_property.name == property_name) {
- return config_property.validator->validate(property_name,
property_value).valid();
+ for (const auto& [config_property_name, config_property_validator]:
Configuration::CONFIGURATION_PROPERTIES) {
+ if (config_property_name == property_name) {
+ return config_property_validator->validate(property_name,
property_value).valid();
Review Comment:
Now that it's not a vector anymore, there is a more efficient way to do
lookup in CONFIGURATION_PROPERTIES
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
