lordgamez commented on code in PR #1545:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1545#discussion_r1164200756


##########
.github/workflows/ci.yml:
##########
@@ -156,6 +159,14 @@ jobs:
         run: cd build && make shellcheck
       - id: flake8_check
         run: cd build && make flake8
+      - id: coverage

Review Comment:
   I thought it would be useful for the developers to see the test coverage in 
case of a newly implemented feature, but I suppose that could be done manually 
on their local environment and the CI would only generate on every push on 
main. I updated the PR with this condition in 
ba58ef2cd8438a314eb6bfd5ab25e46335e87be7



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to