[GitHub] [nifi-minifi-cpp] fgerlits commented on a diff in pull request #1553: MINIFICPP-2094 Change validators from shared to raw pointers

[via GitHub]

fgerlits commented on code in PR #1553:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1553#discussion_r1165098248


##########
libminifi/include/core/CachedValueValidator.h:
##########
@@ -67,29 +67,21 @@ class CachedValueValidator {
     return *this;
   }
 
-  explicit CachedValueValidator(const std::shared_ptr<PropertyValidator>& 
other) : validator_(other) {}
+  explicit CachedValueValidator(const gsl::not_null<const PropertyValidator*> 
other) : validator_(other) {}

Review Comment:
   done in 1a816b300b0dd3be28f8a5c55188893fca238159



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org