szaszm commented on code in PR #1552:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1552#discussion_r1172407058
##########
extensions/windows-event-log/wel/JSONUtils.cpp:
##########
@@ -59,29 +60,50 @@ rapidjson::Value xmlDocumentToJSON(const pugi::xml_node&
node, rapidjson::Docume
return children;
}
-void simplifiedGenericXmlToJson(const pugi::xml_node& source_node,
rapidjson::Value& output_value, rapidjson::Document& allocator_source_document,
bool flatten = false) {
+void simplifiedGenericXmlToJson(const pugi::xml_node& source_node,
+ rapidjson::Value& output_value,
+ rapidjson::Document::AllocatorType& allocator,
+ std::optional<std::string> prefix_for_flat_structure) {
Review Comment:
We should document somewhere, that this has value when the format is
flattened, and empty when the format is simple json. A comment or a boolean
like `const bool is_flattened = prefix_for_flat_structure.has_value();` could
both achieve this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
