[ 
https://issues.apache.org/jira/browse/NIFI-3103?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15696893#comment-15696893
 ] 

ASF GitHub Bot commented on NIFI-3103:
--------------------------------------

GitHub user ijokarumawak opened a pull request:

    https://github.com/apache/nifi/pull/1272

    NIFI-3103: Exclude localhost.cert from RAT check.

    Thank you for submitting a contribution to Apache NiFi.
    
    In order to streamline the review of the contribution we ask you
    to ensure the following steps have been taken:
    
    ### For all changes:
    - [x] Is there a JIRA ticket associated with this PR? Is it referenced 
         in the commit message?
    
    - [x] Does your PR title start with NIFI-XXXX where XXXX is the JIRA number 
you are trying to resolve? Pay particular attention to the hyphen "-" character.
    
    - [x] Has your PR been rebased against the latest commit within the target 
branch (typically master)?
    
    - [x] Is your initial contribution a single, squashed commit?
    
    ### For code changes:
    - [x] Have you ensured that the full suite of tests is executed via mvn 
-Pcontrib-check clean install at the root nifi folder?
    
    ### Note:
    Please ensure that once the PR is submitted, you check travis-ci for build 
issues and submit an update to your PR as soon as possible.
    


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/ijokarumawak/nifi nifi-3103

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/nifi/pull/1272.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1272
    
----
commit fb082ea8c975eb6a787d9bd6492b3791e8ab6573
Author: Koji Kawamura <ijokaruma...@apache.org>
Date:   2016-11-25T23:24:14Z

    NIFI-3103: Exclude localhost.cert from RAT check.

----


> nifi-websocket-services-jetty Rat check failed on Windows
> ---------------------------------------------------------
>
>                 Key: NIFI-3103
>                 URL: https://issues.apache.org/jira/browse/NIFI-3103
>             Project: Apache NiFi
>          Issue Type: Bug
>          Components: Extensions
>         Environment: Windows
>            Reporter: Koji Kawamura
>            Assignee: Koji Kawamura
>
> nifi-websocket-services-jetty should have apache-rat-plugin exclude 
> configuration in its pom.xml like other projects do, such as nifi-toolkit-tls.
> It failed to pass Rat check on Windows with following error:
> {code}
> *****************************************************
> Summary
> -------
> Generated at: 2016-11-25T11:27:37-05:00
> Notes: 0
> Binaries: 2
> Archives: 0
> Standards: 15
> Apache Licensed: 14
> Generated Documents: 0
> JavaDocs are generated and so license header is optional
> Generated files do not required license headers
> 1 Unknown Licenses
> *******************************
> Unapproved licenses:
> C:/development/nifi-1.1.0/nifi-nar-bundles/nifi-websocket-bundle/nifi-websocket-services-jetty/src/test/resources/certs/localhost.crt
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to