lordgamez commented on code in PR #1568:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1568#discussion_r1189854105
##########
libminifi/include/c2/ControllerSocketProtocol.h:
##########
@@ -61,6 +66,46 @@ class ControllerSocketProtocol {
std::weak_ptr<ControllerSocketReporter> controller_socket_reporter_;
std::shared_ptr<Configure> configuration_;
std::shared_ptr<core::logging::Logger> logger_ =
core::logging::LoggerFactory<ControllerSocketProtocol>::getLogger();
+ std::mutex initialization_mutex_;
+
+ // Some commands need to restart the controller socket to reinitialize the
socket with new data for example new SSL data in case of a flow update
+ // These commands are handled on a separate thread, and while these commands
are handled other incoming commands are dropped
+ class SocketRestartCommandProcessor {
Review Comment:
The reason the controller socket is inside the FlowController is because it
can be effected by the flow update. If the controller socket uses SSL the SSL
context may be read from the flow configuration file. If the flow config
changes the socket has to be restarted in case there is a change in the used
SSLContextService.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
