exceptionfactory commented on code in PR #7313: URL: https://github.com/apache/nifi/pull/7313#discussion_r1213329757
########## nifi-nar-bundles/nifi-jms-bundle/nifi-jms-processors/src/test/java/org/apache/nifi/jms/cf/JndiJmsConnectionFactoryProviderTest.java: ########## @@ -0,0 +1,125 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.nifi.jms.cf; + +import org.apache.nifi.reporting.InitializationException; +import org.apache.nifi.util.NoOpProcessor; +import org.apache.nifi.util.TestRunner; +import org.apache.nifi.util.TestRunners; +import org.junit.jupiter.api.AfterAll; +import org.junit.jupiter.api.BeforeAll; +import org.junit.jupiter.api.BeforeEach; +import org.junit.jupiter.api.Test; + +public class JndiJmsConnectionFactoryProviderTest { + + private static final String SERVICE_ID = JndiJmsConnectionFactoryProvider.class.getSimpleName(); + + private static final String CONTEXT_FACTORY = "ContextFactory"; + + private static final String FACTORY_NAME = "ConnectionFactory"; + + private static final String TCP_PROVIDER_URL = "tcp://127.0.0.1"; + + private static final String LDAP_PROVIDER_URL = "ldap://127.0.0.1";; + + private static final String TEST_PROVIDER_URL = "test://127.0.0.1"; + + private static final String HOST_PORT_URL = "127.0.0.1:1024"; + + private static final String ALLOWED_URL_SCHEMES = "tcp test"; + + private static final String LDAP_CONTEXT_FACTORY = "com.sun.jndi.ldap.LdapCtxFactory"; + + private TestRunner runner; + + private JndiJmsConnectionFactoryProvider provider; + + @BeforeAll + static void setProperties() { + System.setProperty(JndiJmsConnectionFactoryProperties.URL_SCHEMES_ALLOWED_PROPERTY, ALLOWED_URL_SCHEMES); + } + + @AfterAll + static void clearProperties() { + System.clearProperty(JndiJmsConnectionFactoryProperties.URL_SCHEMES_ALLOWED_PROPERTY); + } + + @BeforeEach + void setRunner() throws InitializationException { + runner = TestRunners.newTestRunner(NoOpProcessor.class); + provider = new JndiJmsConnectionFactoryProvider(); + runner.addControllerService(SERVICE_ID, provider); + } + + @Test + void testPropertiesValid() { + setFactoryProperties(); + + runner.setProperty(provider, JndiJmsConnectionFactoryProperties.JNDI_PROVIDER_URL, TCP_PROVIDER_URL); + + runner.assertValid(provider); + } + + @Test + void testPropertiesInvalidUrlNotConfigured() { + setFactoryProperties(); + + runner.assertNotValid(provider); + } + + @Test + void testPropertiesInvalidUrlScheme() { + setFactoryProperties(); + + runner.setProperty(provider, JndiJmsConnectionFactoryProperties.JNDI_PROVIDER_URL, LDAP_PROVIDER_URL); + + runner.assertNotValid(provider); + } + + @Test + void testPropertiesInvalidContextFactory() { + runner.setProperty(provider, JndiJmsConnectionFactoryProperties.JNDI_INITIAL_CONTEXT_FACTORY, LDAP_CONTEXT_FACTORY); + runner.setProperty(provider, JndiJmsConnectionFactoryProperties.JNDI_CONNECTION_FACTORY_NAME, FACTORY_NAME); + runner.setProperty(provider, JndiJmsConnectionFactoryProperties.JNDI_PROVIDER_URL, TCP_PROVIDER_URL); + + runner.assertNotValid(provider); + } + + @Test + void testPropertiesUrlSchemeSystemProperty() { + setFactoryProperties(); + + runner.setProperty(provider, JndiJmsConnectionFactoryProperties.JNDI_PROVIDER_URL, TEST_PROVIDER_URL); + + runner.assertValid(provider); + } Review Comment: Thanks for pointing this out. I adjusted the System property evaluation and changed the test approach to support setting and clearing the System property in the context of a single test method. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
