lordgamez commented on code in PR #1586: URL: https://github.com/apache/nifi-minifi-cpp/pull/1586#discussion_r1223096466
########## libminifi/include/utils/TimeUtil.h: ########## @@ -189,6 +189,20 @@ inline bool unit_matches<std::chrono::days>(const std::string& unit) { return unit == "d" || unit == "day" || unit == "days"; } +template<> +inline bool unit_matches<std::chrono::weeks>(const std::string& unit) { + return unit == "w" || unit == "week" || unit == "weeks"; +} + +template<> +inline bool unit_matches<std::chrono::months>(const std::string& unit) { + return unit == "mon" || unit == "month" || unit == "months"; +} + +template<> +inline bool unit_matches<std::chrono::years>(const std::string& unit) { + return unit == "y" || unit == "year" || unit == "years"; +} Review Comment: Updated in latest version -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org