exceptionfactory commented on PR #7194: URL: https://github.com/apache/nifi/pull/7194#issuecomment-1584952966
> @exceptionfactory I found that I had to cut and paste files > > 1. org/apache/nifi/schema/inference/CachedSchemaAccessStrategy.java > > 2. org/apache/nifi/schema/inference/InferSchemaAccessStrategy.java > > 3. org/apache/nifi/schema/inference/SchemaInferenceUtil.java > > 4. org/apache/nifi/util/SchemaInferenceUtil.java > > > Wouldn't it make sense to move these files under module `nifi-schema-inference-utils` so both `nifi-record-serialization-services ` and `nifi-poi-services` could use them ? Yes, given the usage pattern, it moving the `schema.inference` classes to a shared module makes sense. It looks like `nifi-schema-inference-utils` does not depend on `nifi-record-serialization-services-api` right now, which is the reason for their current location. It actually seems like a `nifi-record-serialization-services-shared` module under `nifi-record-serialization-services-bundle` would be a reasonable approach. That would keep the classes closer to their current usage, but also support reuse in `nifi-poi-services` as planned. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
