adamdebreceni commented on code in PR #1584:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1584#discussion_r1229507358
##########
libminifi/test/rocksdb-tests/SwapTests.cpp:
##########
@@ -57,7 +57,7 @@ class OutputProcessor : public core::Processor {
auto ff = session->create();
ff->addAttribute("index", id);
session->write(ff, [&] (const std::shared_ptr<minifi::io::OutputStream>&
output) -> int64_t {
- auto ret = output->write(gsl::span<const char>(id.data(),
id.size()).as_span<const std::byte>());
+ auto ret = output->write(as_bytes(std::span<const char>(id.data(),
id.size())));
Review Comment:
directly calling `as_bytes` on an `std::string` fails, but added `std::span`
ctor
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
